fix: Enable detection of unresponsive or crashed Python backend stub process #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances the detection mechanism for unresponsive or crashed Python backend stub processes by implementing proper process health checks on Unix-like systems.
Key Changes:
- Replaces a simple PID check with
waitpid()to actively detect terminated stub processes on non-Windows platforms - Adds a new
TRITONBACKEND_ModelInstanceReadyfunction to verify stub process health before execution - Ensures proper cleanup by guarding the kill operation with a PID check
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/stub_launcher.cc | Implements waitpid() with WNOHANG to detect process termination and adds guard for kill operations |
| src/python_be.cc | Adds health check function that validates stub process is both active and responsive |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
20 tasks
whoisj
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the detection mechanism for unresponsive or crashed Python backend stub processes.
Key Changes:
waitpid()to actively detect terminated stub processes on non-Windows platformsTRITONBACKEND_ModelInstanceReady, to verify the health of the stub process and accurately report the model's state to the core.